-
Notifications
You must be signed in to change notification settings - Fork 0
🔖Version 0.1.0 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly made some suggestions for the documentation fo the functions.
Testing the functions, I obtained the results that I was expecting. Looks good!
#' @inheritParams import_observations | ||
#' @inheritParams unlikely_status | ||
#' @param conn_reference a connection to the reference database. | ||
#' @export |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#' @inheritParams unlikely_status
This includes the @param
not documented in this function but documented in unlikely_status
. Don't repeat yourself ;-)
Not documenting a function argument will result in a Rcmd_check()
error.
#' @inheritParams sf::st_as_sf | ||
#' @inheritParams sf::st_buffer | ||
#' @inheritParams sf::st_concave_hull | ||
#' @param relevant_area An `sf` object with the relevant area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#' @param dist The size of the buffer (in meters) around each observation.
#' Default of 50.
#' @param crs The coordinate reference system for the observations and the relevant area.
#' Default of 31370 (Belgian Lambert 72).
#' @param ratio A numeric value which controls the concavity of the resulting hull around the observations
#' Default of 0.95
Co-authored-by: raisa_carmen <56317093+RCinbo@users.noreply.github.com>
No description provided.